HeartSaVioR commented on code in PR #45023:
URL: https://github.com/apache/spark/pull/45023#discussion_r1520802905
##########
python/pyspark/sql/datasource.py:
##########
@@ -426,6 +426,10 @@ def read(self, partition: InputPartition) ->
Iterator[Union[Tuple, Row]]:
in the final DataFrame.
"""
...
+ raise PySparkNotImplementedError(
Review Comment:
@chaoqin-li1123
nit: if not needed, let's remove @abstract in the method definition.
Please do this as follow-up PR. I'd like to unblock this PR to let you move
forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
