HiuKwok commented on PR #45500: URL: https://github.com/apache/spark/pull/45500#issuecomment-1994496507
@dongjoon-hyun @LuciferYang During the past few weeks, I managed to re-write / update, all Jetty-related classes, things look fine in most of the Java / Scala classes. However, due to the new handler class structure that Jetty 12 introduced, I'm not sure is that feasible to replicate what `ProxyRedirectHandler` is performing now. If I understand correctly the initial intent of `ProxyRedirectHandler` is to override the redirect behaviour, in the case that Jetty decides to redirect the given request, BEFORE the request reaches any of the servlets. However in Jetty 12, all Jetty handlers are switched to use the Jetty Request and Response wrapper object, hence it's no longer possible to override the redirect behaviour via the `sendRedirect` method call. I have checked on the Jetty upgrade guide, which the guide suggests that all `sendDirect()` should be rewritten with ` Response.sendRedirect(request, response, callback, location)`. However in this case we no longer have to control URL rewrite, because this is a static method from Jetty lib. I wonder if you guys have an idea on this / or if any visible alternative can be implemented instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
