robreeves opened a new pull request, #45504:
URL: https://github.com/apache/spark/pull/45504
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Make the shutdown hook timeout configurable. If this is not defined it falls
back to the existing behavior, which uses a default timeout of 30 seconds, or
whatever is defined in core-site.xml for the hadoop.service.shutdown.timeout
property.
### Why are the changes needed?
Spark sometimes times out during the shutdown process. This results in any
data left in the queues to be dropped and causes metadata data loss (e.g. event
logs, anything written by custom listeners).
This is not easily configurable before this change. The underlying
`org.apache.hadoop.util.ShutdownHookManager` a the default timeout of 30
seconds. It can be configured by setting hadoop.service.shutdown.timeout, but
this must be done in the core-site.xml/core-default.xml because a new hadoop
conf object is created and there is no opportunity to modify it.
### Does this PR introduce _any_ user-facing change?
Yes, a new config `spark.shutdown.timeout` is added.
### How was this patch tested?
Manual testing in spark-shell. This is not easily unit testable.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
