stefankandic commented on code in PR #45517:
URL: https://github.com/apache/spark/pull/45517#discussion_r1525941208
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -4845,6 +4845,22 @@ object functions {
otherChar: Column): Column =
Column.fn("mask", input, upperChar, lowerChar, digitChar, otherChar)
+ /**
+ * Marks a given column with specified collation.
+ *
+ * @group string_funcs
+ * @since 4.0.0
+ */
+ def collate(e: Column, collation: String): Column = Column.fn("collate", e,
lit(collation))
Review Comment:
no, it should always be just the name of the collation eg Unicode or
UTF8_Binary so we should probably keep the string type here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
