dbatomic commented on code in PR #45422:
URL: https://github.com/apache/spark/pull/45422#discussion_r1526193615
##########
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##########
@@ -40,6 +40,7 @@ class StringType private(val collationId: Int) extends
AtomicType with Serializa
* equality and hashing).
*/
def isBinaryCollation: Boolean =
CollationFactory.fetchCollation(collationId).isBinaryCollation
+ def isLowercaseCollation: Boolean = collationId ==
CollationFactory.LOWERCASE_COLLATION_ID
Review Comment:
Can you remove even this guy and push the check into `StringTypeBinaryLcase`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
