dongjoon-hyun commented on PR #45588: URL: https://github.com/apache/spark/pull/45588#issuecomment-2008617318
Is this correct? > Before, we read a smallint(db) as int(spark) in getCatalytType, and then we write an IntegerType(spark) to smallint(db) in getJDBCType According to `getCommonJDBCType`, `IntegerType(spark)` seems to go `java.sql.Types.INTEGER` instead of `java.sql.Types.SMALLINT`? Maybe, did I miss something in MySQLDialect? https://github.com/apache/spark/blob/61d7b0f24fc9699d71d0f0c4ca7c162ea55507ea/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala#L142-L146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
