xleoken commented on code in PR #45609: URL: https://github.com/apache/spark/pull/45609#discussion_r1533099686
########## sql/core/src/main/scala/org/apache/spark/sql/jdbc/HiveDialect.scala: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.jdbc + +import java.util.Locale + +import org.apache.spark.sql.catalyst.SQLConfHelper + +private case object HiveDialect extends JdbcDialect with SQLConfHelper { + + override def canHandle(url : String): Boolean = + url.toLowerCase(Locale.ROOT).startsWith("jdbc:hive2") Review Comment: hi @dongjoon-hyun, thanks for your review. Your considerations are correct, but this patch is applicable to both `Hive Thrift Server` and `Spart Thrift Server`. > You want to achieve to introduce Hive-specific syntax via this HiveDialect instead of Spark Thrift Server, right? Actually, it's not. I used `sbin/start-thriftserver.sh` in the production environment. > I'm not sure HiveDialect is a valid name in Apache Spark community OK, `HiveDialect` seems better for `jdbc:hive2`. In the future, if encountering Hive-specific syntax or SparkSQL-specific syntax issue, we can distinguish between Hive and Spark in specific methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
