dongjoon-hyun commented on code in PR #45228: URL: https://github.com/apache/spark/pull/45228#discussion_r1533275990
########## core/src/main/scala/org/apache/spark/internal/config/package.scala: ########## @@ -551,6 +551,22 @@ package object config { .checkValue(_.endsWith(java.io.File.separator), "Path should end with separator.") .createOptional + private[spark] val STORAGE_FALLBACK_STORAGE_NUM_THREADS_FOR_SHUFFLE_READ = + ConfigBuilder("spark.storage.fallbackStorage.num.threads.for.shuffle.read") Review Comment: Every `.` means a new namespace in Apache Spark configuration namespace scheme. For example, this line introduces 4 new namespaces. Please avoid using `.`. - spark.storage.fallbackStorage.num.* - spark.storage.fallbackStorage.num.threads.* - spark.storage.fallbackStorage.num.threads.for.* - spark.storage.fallbackStorage.num.threads.for.shuffle.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org