Ngone51 commented on code in PR #45631:
URL: https://github.com/apache/spark/pull/45631#discussion_r1535000136
##########
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala:
##########
@@ -2654,18 +2659,21 @@ class TaskSchedulerImplSuite extends SparkFunSuite with
LocalSparkContext
taskScheduler.submitTasks(lowerTaskSet)
taskScheduler.submitTasks(higherRpTaskSet)
- // only offer the resources to the higher taskset
+ // Initially, offer the available resources to the higher priority task
set, where each task
+ // requires 0.7 GPU, so Spark can assign the GPU resources to a
maximum of 4 tasks, leaving
+ // 0.3 GPU available for each remaining tasks.
+ // Secondly, try to offer the available resources to the lower priority
task set, where each
+ // task requires 0.4 GPU, while only 0.3 gpu of each address is
available, so couldn't
+ // offer any resources for the lower tasks.
Review Comment:
It looks `lowerTaskSet` is summitted before `higherRpTaskSet`? So it's
actually requires 0.4 GPU per task first and then 0.7 GPU per task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
