gengliangwang commented on code in PR #45729: URL: https://github.com/apache/spark/pull/45729#discussion_r1540312938
########## common/utils/src/main/scala/org/apache/spark/internal/Logging.scala: ########## @@ -55,6 +77,43 @@ trait Logging { log_ } + implicit class LogStringContext(val sc: StringContext) { + def log(args: Any*): (String, Option[Instance]) = { + val processedParts = sc.parts.iterator + val sb = new StringBuilder(processedParts.next()) + lazy val map = new java.util.HashMap[String, String]() + + args.foreach { arg => + arg match { Review Comment: There is another code block at the end of the loop: ``` if (processedParts.hasNext) { sb.append(processedParts.next()) } ``` I am trying to build both the map and the string in one loop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org