sebastianhillig-db commented on code in PR #45635:
URL: https://github.com/apache/spark/pull/45635#discussion_r1542043094
##########
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala:
##########
@@ -95,10 +95,20 @@ private[spark] class PythonWorkerFactory(
def create(): (PythonWorker, Option[Long]) = {
if (useDaemon) {
self.synchronized {
- if (idleWorkers.nonEmpty) {
+ // Pull from idle workers until we one that is alive, otherwise create
a new one.
+ while (idleWorkers.nonEmpty) {
val worker = idleWorkers.dequeue()
- worker.selectionKey.interestOps(SelectionKey.OP_READ |
SelectionKey.OP_WRITE)
- return (worker, daemonWorkers.get(worker))
+ val workerHandle = daemonWorkers(worker)
Review Comment:
Since the idleWorkers queue keeps the reference alive, there should never be
a case where the daemonWorker disappears until it is retrieved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
