jingz-db commented on code in PR #45709: URL: https://github.com/apache/spark/pull/45709#discussion_r1541998642
########## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala: ########## @@ -188,9 +187,12 @@ class TimerStateImpl( /** * Function to get all the registered timers for all grouping keys + * @param expiryTimestampMs Threshold for expired timestamp in milliseconds, this function Review Comment: Thanks for pointing this out (I did not realize this before but looks like we did the right thing)! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org