cloud-fan commented on code in PR #45735: URL: https://github.com/apache/spark/pull/45735#discussion_r1542278308
########## launcher/src/main/java/org/apache/spark/launcher/JVMRuntimeOptions.java: ########## @@ -18,14 +18,14 @@ package org.apache.spark.launcher; /** - * This helper class is used to place the all `--add-opens` options - * required by Spark when using Java 17. `DEFAULT_MODULE_OPTIONS` has added + * This helper class is used to place some JVM runtime options(eg: `--add-opens`) + * required by Spark when using Java 17. `DEFAULT_OPTIONS` has added * `-XX:+IgnoreUnrecognizedVMOptions` to be robust. * * @since 3.3.0 Review Comment: If this is a public API, let's not touch it. We can correct the doc comments though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
