zhengruifeng commented on code in PR #45150:
URL: https://github.com/apache/spark/pull/45150#discussion_r1546115268
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -265,4 +265,11 @@ object Connect {
.version("4.0.0")
.bytesConf(ByteUnit.BYTE)
.createWithDefault(1024)
+
+ val CONNECT_PROGRESS_REPORT_INTERVAL =
+ buildStaticConf("spark.connect.progress.reportInterval")
+ .doc("The interval at which the progress of a query is reported to the
client.")
+ .version("4.0.0")
+ .timeConf(TimeUnit.MILLISECONDS)
+ .createWithDefaultString("2s")
Review Comment:
What about making this config accept '-1' value? and disable this feature if
the value is negative
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -265,4 +265,11 @@ object Connect {
.version("4.0.0")
.bytesConf(ByteUnit.BYTE)
.createWithDefault(1024)
+
+ val CONNECT_PROGRESS_REPORT_INTERVAL =
Review Comment:
Does it make sense to make it a runtime config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
