cloud-fan commented on code in PR #45383: URL: https://github.com/apache/spark/pull/45383#discussion_r1546396569
########## sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala: ########## @@ -27,7 +27,9 @@ import org.apache.spark.sql.catalyst.util.CollationFactory * @param collationId The id of collation for this StringType. */ @Stable -class StringType private(val collationId: Int) extends AtomicType with Serializable { +class StringType private(val collationId: Int, var isExplicit: Boolean = false) Review Comment: why it's a `var`? does it need to be mutable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org