pkotikalapudi commented on code in PR #42352: URL: https://github.com/apache/spark/pull/42352#discussion_r1548712982
########## core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala: ########## @@ -185,6 +195,12 @@ private[spark] class ExecutorAllocationManager( * If not, throw an appropriate exception. */ private def validateSettings(): Unit = { + + if ( streamingDRAFeatureEnabled && !Utils.isDynamicAllocationEnabled(conf) ) { Review Comment: I just realized that we are doing Utils.isDynamicAllocationEnabled(conf) check before creating ExecutorAllocationManager object at [spark context](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/SparkContext.scala#L663). I will remove this check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org