uros-db commented on code in PR #45791:
URL: https://github.com/apache/spark/pull/45791#discussion_r1551446372
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -176,15 +176,29 @@ public Collation(
*/
public static StringSearch getStringSearch(
- final UTF8String left,
- final UTF8String right,
+ final UTF8String targetUTF8String,
+ final UTF8String patternUTF8String,
final int collationId) {
- String pattern = right.toString();
- CharacterIterator target = new StringCharacterIterator(left.toString());
+
Review Comment:
I think what Stefan is saying (in the comment below) that we shouldn't have
unhandled parameter values, especially not in a public method. In this case, I
would just add here something like:
```
if (collationId == UTF8_BINARY_COLLATION_ID) {
return getStringSearch(targetUTF8String, patternUTF8String);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
