HyukjinKwon commented on code in PR #45826: URL: https://github.com/apache/spark/pull/45826#discussion_r1552784399
########## python/pyspark/sql/types.py: ########## @@ -1468,6 +1475,36 @@ def __eq__(self, other: Any) -> bool: return type(self) == type(other) +class VariantVal: Review Comment: I think he was suggesting to put `VariantVal` into somewhere else e.g., making a separate file `vairent.py`, and put all related things into that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org