cloud-fan commented on code in PR #45694:
URL: https://github.com/apache/spark/pull/45694#discussion_r1555285066
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/StringTypeCollated.scala:
##########
@@ -30,6 +30,7 @@ abstract class StringTypeCollated extends AbstractDataType {
* Use StringTypeBinary for expressions supporting only binary collation.
*/
case object StringTypeBinary extends StringTypeCollated {
+ // TODO (SPARK-47504): Rename this AbstractDataType's simpleString when it
is first used
Review Comment:
can we fix it now as we know it should be `"string"`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
