milastdbx commented on PR #45895: URL: https://github.com/apache/spark/pull/45895#issuecomment-2042987166
@dongjoon-hyun thanks for the review. You are absolutely right. Your tests are passing because you are running them in batch, and this regression only really happens if you call don't initalize `LogicalTypes` prior to resolving schema, hence I would assume that some test registered it and as a side effect you get tests passing. Given that `LogicalTypes` is an external static class, part of `Apache Avro` I am not sure how to resolve this reliably. One idea is to separate this into different Suite, but this also does not give complete protection, as multiple suites can be run within same process, hence hitting same issue as if test was part of suite. Do you have any suggestion how to test this static object initalization when we do not have access to `teardown` api of these classes ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
