itholic commented on code in PR #45876:
URL: https://github.com/apache/spark/pull/45876#discussion_r1556661227
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##########
@@ -686,17 +687,19 @@ private[hive] class HiveClientImpl(
} catch {
case e: Exception =>
val remainingParts = matchingParts.toBuffer --= droppedParts
+ // scalastyle:off line.size.limit
logError(
s"""
|======================
- |Attempt to drop the partition specs in table '$table' database
'$db':
+ |Attempt to drop the partition specs in table
'${MDC(TABLE_NAME, table)}' database '${MDC(DB_NAME, db)}':
|${specs.mkString("\n")}
|In this attempt, the following partitions have been dropped
successfully:
|${droppedParts.mkString("\n")}
|The remaining partitions have not been dropped:
|${remainingParts.mkString("\n")}
Review Comment:
Hi, @panbingkun I wonder if you could advise me how can we handle those
variables which are made via `mkString`.
They would contains multiple items split by `"\n"`, but can we still just
make them as a `LogKey`??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
