gengliangwang commented on code in PR #45926:
URL: https://github.com/apache/spark/pull/45926#discussion_r1558920991
##########
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetCatalogsOperation.scala:
##########
@@ -40,7 +41,7 @@ private[hive] class SparkGetCatalogsOperation(
override def runInternal(): Unit = {
val logMsg = "Listing catalogs"
- logInfo(s"$logMsg with $statementId")
+ logInfo(log"${MDC(LOG_MESSAGE, logMsg)} with ${MDC(STATEMENT_ID,
statementId)}")
Review Comment:
logMsg is constant. Let's not make it MDC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
