gengliangwang commented on code in PR #45975: URL: https://github.com/apache/spark/pull/45975#discussion_r1560473661
########## common/utils/src/main/scala/org/apache/spark/internal/Logging.scala: ########## @@ -37,7 +37,10 @@ import org.apache.spark.util.SparkClassUtils * The values of the MDC will be inline in the log message, while the key-value pairs will be * part of the ThreadContext. */ -case class MDC(key: LogKey, value: Any) +case class MDC(key: LogKey, value: Any) { + require(!value.isInstanceOf[MessageWithContext], Review Comment: I am concerned that there is a mistake and we didn't capture it before release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org