mihailom-db commented on code in PR #45933: URL: https://github.com/apache/spark/pull/45933#discussion_r1560981825
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ########## @@ -2690,7 +2690,7 @@ case class StringDecode(bin: Expression, charset: Expression, legacyCharsets: Bo override def left: Expression = bin override def right: Expression = charset override def dataType: DataType = StringType Review Comment: Shouldn't this return default collation? ########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ########## @@ -2949,7 +2950,7 @@ case class FormatNumber(x: Expression, d: Expression) override def dataType: DataType = StringType override def nullable: Boolean = true Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
