urosstan-db commented on code in PR #45985:
URL: https://github.com/apache/spark/pull/45985#discussion_r1561134186
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala:
##########
@@ -118,12 +117,8 @@ class DataSourceV2Strategy(session: SparkSession) extends
Strategy with Predicat
val rdd = v1Relation.buildScan()
val unsafeRowRDD = DataSourceStrategy.toCatalystRDD(v1Relation, output,
rdd)
- val tableIdentifier = v2Relation.identifier.map(_.asMultipartIdentifier)
match {
- case Some(Seq(schema, tableName)) =>
- Some(new TableIdentifier(tableName, Some(schema),
v2Relation.catalog.map(_.name())))
- case _ =>
- None
- }
+ val catalogName = v2Relation.catalog.map(_.name())
+ val tableIdentifier =
v2Relation.identifier.flatMap(_.asTableIdentifier(catalogName))
Review Comment:
This is only for telemetry and Spark UI, before initial change (one month
ago), table identifier was null. IMO we should not risk regression for the
purpose of telemetry and observability, whenever we get multipart identifier,
the exception will be thrown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
