LuciferYang commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1561970178
##########
core/src/main/scala/org/apache/spark/api/python/WriteInputFormatTestDataGenerator.scala:
##########
@@ -56,33 +57,39 @@ case class TestWritable(var str: String, var int: Int, var
double: Double) exten
}
}
+@deprecated("This class will be move to `test`.", "3.5.2")
private[python] class TestInputKeyConverter extends Converter[Any, Any] {
override def convert(obj: Any): Char = {
obj.asInstanceOf[IntWritable].get().toChar
}
}
+@deprecated("This class will be move to `test`.", "3.5.2")
private[python] class TestInputValueConverter extends Converter[Any, Any] {
override def convert(obj: Any): ju.List[Double] = {
val m = obj.asInstanceOf[MapWritable]
m.keySet.asScala.map(_.asInstanceOf[DoubleWritable].get()).toSeq.asJava
}
}
+@deprecated("This class will be move to `test`.", "3.5.2")
private[python] class TestOutputKeyConverter extends Converter[Any, Any] {
override def convert(obj: Any): Text = {
new Text(obj.asInstanceOf[Int].toString)
}
}
+@deprecated("This class will be move to `test`.", "3.5.2")
private[python] class TestOutputValueConverter extends Converter[Any, Any] {
Review Comment:
`private[python]` probably doesn't need to add `@deprecated`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
