GideonPotok opened a new pull request, #46040:
URL: https://github.com/apache/spark/pull/46040
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
https://issues.apache.org/jira/browse/SPARK-46830
### What changes were proposed in this pull request?
Add collation support to types of return values for calls to substr, left,
right, when passed in arguments of an explicit, implicit, or session-specified
collations. Add tests to validate behavior.
### Why are the changes needed?
We are incrementally adding collation support to built-in string functions
in Spark. These functions are intended to be supported for collated types.
### Does this PR introduce _any_ user-facing change?
these sql functions will now not throw errors when passed in collated types.
Instead, they will return the right value, of the passed in type. Or of the
default collation.
### How was this patch tested?
Unit testing + ad-hoc spark shell and pyspark shell interactions.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
