cloud-fan commented on code in PR #45896:
URL: https://github.com/apache/spark/pull/45896#discussion_r1565753990
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AbstractSqlParser.scala:
##########
@@ -30,50 +32,74 @@ abstract class AbstractSqlParser extends AbstractParser
with ParserInterface {
override def astBuilder: AstBuilder
/** Creates Expression for a given SQL string. */
- override def parseExpression(sqlText: String): Expression = parse(sqlText) {
parser =>
- val ctx = parser.singleExpression()
- withOrigin(ctx, Some(sqlText)) {
- astBuilder.visitSingleExpression(ctx)
+ override def parseExpression(sqlText: String): Expression =
+ parse(sqlText) { parser =>
+ val ctx = parser.singleExpression()
+ withOrigin[Expression](ctx, Some(sqlText)) {
+ withErrorHandling(ctx) {
+ astBuilder.visitSingleExpression(ctx)
+ }
+ }
}
- }
/** Creates TableIdentifier for a given SQL string. */
- override def parseTableIdentifier(sqlText: String): TableIdentifier =
parse(sqlText) { parser =>
- astBuilder.visitSingleTableIdentifier(parser.singleTableIdentifier())
Review Comment:
oh nvm, some do not have parser context
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AbstractSqlParser.scala:
##########
@@ -30,50 +32,74 @@ abstract class AbstractSqlParser extends AbstractParser
with ParserInterface {
override def astBuilder: AstBuilder
/** Creates Expression for a given SQL string. */
- override def parseExpression(sqlText: String): Expression = parse(sqlText) {
parser =>
- val ctx = parser.singleExpression()
- withOrigin(ctx, Some(sqlText)) {
- astBuilder.visitSingleExpression(ctx)
+ override def parseExpression(sqlText: String): Expression =
+ parse(sqlText) { parser =>
+ val ctx = parser.singleExpression()
+ withOrigin[Expression](ctx, Some(sqlText)) {
+ withErrorHandling(ctx) {
+ astBuilder.visitSingleExpression(ctx)
+ }
+ }
}
- }
/** Creates TableIdentifier for a given SQL string. */
- override def parseTableIdentifier(sqlText: String): TableIdentifier =
parse(sqlText) { parser =>
- astBuilder.visitSingleTableIdentifier(parser.singleTableIdentifier())
Review Comment:
oh nvm, some do not have parser context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
