uros-db commented on code in PR #46082: URL: https://github.com/apache/spark/pull/46082#discussion_r1570123925
########## sql/core/benchmarks/CollationNonASCIIBenchmark-jdk21-results.txt: ########## @@ -1,54 +1,54 @@ -OpenJDK 64-Bit Server VM 21.0.2+13-LTS on Linux 6.5.0-1017-azure +OpenJDK 64-Bit Server VM 21.0.3+9-LTS on Linux 6.5.0-1018-azure AMD EPYC 7763 64-Core Processor collation unit benchmarks - equalsFunction: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative -------------------------------------------------------------------------------------------------------------------------- -UTF8_BINARY_LCASE 18244 18258 20 0.0 456096.4 1.0X -UNICODE 498 498 0 0.1 12440.3 36.7X -UTF8_BINARY 499 500 1 0.1 12467.7 36.6X -UNICODE_CI 13429 13443 19 0.0 335725.4 1.4X +UTF8_BINARY_LCASE 18412 18491 113 0.0 460288.0 1.0X Review Comment: is the performance for `UTF8_BINARY_LCASE` worse for all expressions (contains, startsWith, endsWith)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org