harshmotw-db commented on code in PR #46122: URL: https://github.com/apache/spark/pull/46122#discussion_r1571385965
########## common/variant/src/main/java/org/apache/spark/types/variant/VariantBuilder.java: ########## @@ -223,7 +223,7 @@ public void appendFloat(float f) { public void appendBinary(byte[] binary) { checkCapacity(1 + U32_SIZE + binary.length); - writeBuffer[writePos++] = primitiveHeader(LONG_STR); + writeBuffer[writePos++] = primitiveHeader(BINARY); Review Comment: Yes, I'll try to resolve it. I think I've made a bit of a mess with the master branch in my fork. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org