cloud-fan commented on code in PR #46120:
URL: https://github.com/apache/spark/pull/46120#discussion_r1571683122
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ConstantFoldingSuite.scala:
##########
@@ -437,6 +437,21 @@ class ConstantFoldingSuite extends PlanTest {
Optimize.execute(oneRowScalarSubquery),
oneRowScalarSubquery)
}
+
+ test("Current time functions are constant folded") {
Review Comment:
I think what we need is an analyzer test to make sure we can use
current_time in functions that require folding input, like `rand`. How about we
move the test to `ExpressionTypeCheckingSuite`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
