zhengruifeng commented on code in PR #46128:
URL: https://github.com/apache/spark/pull/46128#discussion_r1571771431
##########
python/pyspark/sql/connect/functions/builtin.py:
##########
@@ -3775,16 +3775,14 @@ def hll_sketch_agg(col: "ColumnOrName", lgConfigK:
Optional[Union[int, Column]]
hll_sketch_agg.__doc__ = pysparkfuncs.hll_sketch_agg.__doc__
-def hll_union_agg(col: "ColumnOrName", allowDifferentLgConfigK: Optional[bool]
= None) -> Column:
+def hll_union_agg(
+ col: "ColumnOrName",
+ allowDifferentLgConfigK: Optional[Union[bool, Column]] = None,
+) -> Column:
if allowDifferentLgConfigK is None:
return _invoke_function_over_columns("hll_union_agg", col)
else:
- _allowDifferentLgConfigK = (
- lit(allowDifferentLgConfigK)
- if isinstance(allowDifferentLgConfigK, bool)
- else allowDifferentLgConfigK
- )
- return _invoke_function_over_columns("hll_union_agg", col,
_allowDifferentLgConfigK)
+ return _invoke_function_over_columns("hll_union_agg", col,
lit(allowDifferentLgConfigK))
Review Comment:
function `lit` accepts both `bool` and `Column`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
