panbingkun commented on code in PR #46147:
URL: https://github.com/apache/spark/pull/46147#discussion_r1575868146


##########
dev/checkstyle.xml:
##########
@@ -196,6 +196,17 @@
             <property name="format" value="@Test\(expected"/>
             <property name="message" value="Please use the `assertThrows` 
method to test for exceptions." />
         </module>
+        <module name="RegexpSinglelineJava">

Review Comment:
   The rule on the `java side` is `slightly different` from `scala side` 
because the following code is not allowed on the java side:
   ```
   xxx.toUpperCase // no ()
   xxx.toLowerCase // no ()
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to