rangadi commented on code in PR #46125:
URL: https://github.com/apache/spark/pull/46125#discussion_r1576629583
##########
core/src/main/scala/org/apache/spark/api/python/StreamingPythonRunner.scala:
##########
@@ -91,11 +91,27 @@ private[spark] class StreamingPythonRunner(
new
BufferedInputStream(pythonWorker.get.channel.socket().getInputStream,
bufferSize))
val resFromPython = dataIn.readInt()
+ if (resFromPython != 0) {
+ val errMessage = PythonWorkerUtils.readUTF(dataIn)
+ throw streamingPythonRunnerDidNotInitialize(resFromPython, errMessage)
+ }
logInfo(s"Runner initialization succeeded (returned $resFromPython).")
(dataOut, dataIn)
}
+ def streamingPythonRunnerDidNotInitialize(resFromPython: Int, errMessage:
String):
Review Comment:
minor: rename to '...RunnerInitializationFailure' or '...FailedToInitialize'
...
##########
core/src/main/scala/org/apache/spark/api/python/StreamingPythonRunner.scala:
##########
@@ -91,11 +91,27 @@ private[spark] class StreamingPythonRunner(
new
BufferedInputStream(pythonWorker.get.channel.socket().getInputStream,
bufferSize))
val resFromPython = dataIn.readInt()
+ if (resFromPython != 0) {
+ val errMessage = PythonWorkerUtils.readUTF(dataIn)
+ throw streamingPythonRunnerDidNotInitialize(resFromPython, errMessage)
+ }
logInfo(s"Runner initialization succeeded (returned $resFromPython).")
(dataOut, dataIn)
}
+ def streamingPythonRunnerDidNotInitialize(resFromPython: Int, errMessage:
String):
+ StreamingPythonRunnerInitializationException = {
+ new StreamingPythonRunnerInitializationException(resFromPython, errMessage)
+ }
+
+ class StreamingPythonRunnerInitializationException(resFromPython: Int,
errMessage: String)
+ extends SparkPythonException(
+ errorClass = "STREAMING_PYTHON_RUNNER_DID_NOT_INITIALIZE",
Review Comment:
Similar rename here. This is what user will see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
