peter-toth commented on code in PR #37630:
URL: https://github.com/apache/spark/pull/37630#discussion_r1577416702


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/MergeScalarSubqueries.scala:
##########
@@ -21,7 +21,7 @@ import scala.collection.mutable
 import scala.collection.mutable.ArrayBuffer
 
 import org.apache.spark.sql.catalyst.expressions._
-import org.apache.spark.sql.catalyst.expressions.aggregate.AggregateExpression
+import 
org.apache.spark.sql.catalyst.expressions.aggregate.{AggregateExpression}

Review Comment:
   I don't know what to do with this PR. There doesn't seem to be much 
interrest in this improvement from the community, but I'm happy to fix this if 
we can move forward somehow...
   
   My plan was:
   1.  to allow filter merging for subqueries in this PR,
   2. and then extract the merging logic to be able to apply it on other areas 
of the plan,
   3. and then apply it on other areas like 
https://github.com/apache/spark/pull/40661.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to