dongjoon-hyun commented on code in PR #46318:
URL: https://github.com/apache/spark/pull/46318#discussion_r1586626193
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:
##########
@@ -4750,12 +4750,13 @@ class SQLQuerySuite extends QueryTest with
SharedSparkSession with AdaptiveSpark
}
test("SPARK-47939: Explain should work with parameterized queries") {
- def checkQueryPlan(df: DataFrame, plan: String): Unit = assert(
- df.collect()
+ def checkQueryPlan(df: DataFrame, plan: String): Unit = {
Review Comment:
Well, this is only for this single test case instead of the whole
`SQLQuerySuite`. It would be great if the PR title could describe more
precisely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
