gengliangwang commented on code in PR #46309:
URL: https://github.com/apache/spark/pull/46309#discussion_r1586662318
##########
core/src/main/scala/org/apache/spark/deploy/master/Master.scala:
##########
@@ -1294,7 +1293,7 @@ private[deploy] class Master(
if (worker.state != WorkerState.DEAD) {
val workerTimeoutSecs =
TimeUnit.MILLISECONDS.toSeconds(workerTimeoutMs)
logWarning(log"Removing ${MDC(LogKeys.WORKER_ID, worker.id)} because
we got no heartbeat " +
- log"in ${MDC(LogKeys.TIME_UNITS, workerTimeoutSecs)} seconds")
+ log"in ${MDC(LogKeys.TIME_UNITS, workerTimeoutSecs * 1000)} ms")
Review Comment:
we can use workerTimeoutMs directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
