parthchandra commented on code in PR #46402:
URL: https://github.com/apache/spark/pull/46402#discussion_r1592803402
##########
connector/profiler/pom.xml:
##########
@@ -45,6 +48,7 @@
<groupId>me.bechberger</groupId>
<artifactId>ap-loader-all</artifactId>
<version>3.0-8</version>
+ <scope>provided</scope>
Review Comment:
It's great to include this feature in the spark release. I feel though, that
if we are making it available in the release the ap-loader dependency should be
included as well. (Currently, if we build with the jvm-profiler profile, the
dependency is included in the build).
Surprisingly, the jar file is not very large (I have version 2.9.7 and it is
only 830K).
Either way, including this in the release is already a big step so I'm fine
with asking users to download the jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
