SemyonSinchenko commented on code in PR #46368: URL: https://github.com/apache/spark/pull/46368#discussion_r1592933898
########## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala: ########## @@ -283,6 +283,16 @@ class Dataset[T] private[sql] ( def printSchema(level: Int): Unit = println(schema.treeString(level)) // scalastyle:on println + /** + * Returns an approximate size in bytes of the Dataset. + * + * @group basic + * @since 4.0.0 + */ + def sizeInBytesApproximation(): Long = { Review Comment: Thank you! I missed that. I changed the type to BigInteger (bytes[] in proto) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org