sahnib commented on code in PR #45376: URL: https://github.com/apache/spark/pull/45376#discussion_r1593215731
########## sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala: ########## @@ -442,6 +442,16 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] { case EventTimeWatermark(columnName, delay, child) => EventTimeWatermarkExec(columnName, delay, planLater(child)) :: Nil + case UpdateEventTimeWatermarkColumn(columnName, delay, child) => + // we expect watermarkDelay to be resolved before physical planning. + if (delay.isEmpty) { + // This is a sanity check. We should not reach here as delay is updated during + // query plan resolution in [[ResolveUpdateEventTimeWatermarkColumn]] Analyzer rule. + throw SparkException.internalError( + "You hit a query analyzer bug. Please report your query to Spark user mailing list.") Review Comment: Added more detail to the error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org