HeartSaVioR commented on code in PR #46491:
URL: https://github.com/apache/spark/pull/46491#discussion_r1594850804
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -777,10 +777,19 @@ class RocksDB(
.keys.filter(checkInternalColumnFamilies(_)).size
val numExternalColFamilies = colFamilyNameToHandleMap.keys.size -
numInternalColFamilies
+ // if bounded memory usage is enabled, we share the block cache across all
state providers
+ // running on the same node and account the usage to this single cache. In
this case, its not
+ // possible to provide partition level or query level memory usage.
+ val memoryUsage = if (conf.boundedMemoryUsage) {
+ 0L
Review Comment:
Could you please try with -1L? I'd say let's distinguish without doubt if
possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
