Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6502#issuecomment-106994572
@vanzin - thanks, this looks great.
Can you do 3 things?
1. Make the import ordering configurable.
2. The style rule is pretty complicated. Add some unit tests for it.
3. Submit a pull request against scalastyle proper.
The reason is we should avoid one-offs that make it harder to upgrade in
the future. We can merge this as soon as there is a pull request against
scalastyle and way to move forward. And once that is merged into scalastyle and
scalastyle releases a new version, we can remove our one-off rule.
This is what we have done for all the one-off rules in the past.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
