srielau commented on code in PR #46267:
URL: https://github.com/apache/spark/pull/46267#discussion_r1595660959
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1700,6 +1700,16 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
+ val VIEW_SCHEMA_BINDING_MODE = buildConf("spark.sql.viewSchemaBindingMode")
+ .doc("Set to DISABLE to disable the WITH SCHEMA clause for view DDL and
suppress the line in " +
+ " DESCRIBE EXTENDED. The default, and only other value, is COMPENSATION.
Views without " +
+ " WITH SCHEMA clause are defaulted to WITH SCHEMA COMPENSATION.")
+ .version("4.0.0")
+ .stringConf
+ .transform(_.toUpperCase(Locale.ROOT))
+ .checkValues(Set("COMPENSATION", "DISABLED"))
Review Comment:
We did, @gengliangwang raised the concern whether that is needlessly complex.
I have been splitting the baby by removing all but these two. having on/off
config which is not a boolean.
If users demand it we can easily expand the config to more values, if not we
can deprecate the the config and remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
