srielau commented on PR #46267: URL: https://github.com/apache/spark/pull/46267#issuecomment-2103503061
@cloud-fan @gengliangwang I have addressed all comments (except the "override" on the, which intelij and Wenchen appear to be of different opinions). The testsuite has been split up into: * Default behavior depending on config. * 1 file per mode. I don't see a good way to have one file with 4 distinct modes since they have sufficient syntax and test differences that I think "spaghetti" is more readable than trying to maximize shared text. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
