panbingkun commented on PR #46502: URL: https://github.com/apache/spark/pull/46502#issuecomment-2103613069
- According to @gengliangwang's suggestion, we did not migrate the `test` code in the `structured log`, so we need to exclude them, eg: <img width="1020" alt="image" src="https://github.com/apache/spark/assets/15246973/374ec683-5f13-439a-bafa-b7deafdb23dd";> - Other exclusion is: `common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDBIterator.java` <img width="1007" alt="image" src="https://github.com/apache/spark/assets/15246973/8068a294-a631-4ccc-a081-052f72aeb43a";> A.the module `common/kvstore`, because it does not rely on 'utils' when compiling, if we want to `migrate` it, we need to add a `dependency` on 'utils' in `pom.xml` https://github.com/apache/spark/blob/master/common/kvstore/pom.xml#L38-L66 B.And only one place in this module use 'slf4j', as shown below: https://github.com/apache/spark/blob/e1fb1d7e063af7e8eb6e992c800902aff6e19e15/common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDBIterator.java#L324 And we found that this `error` level log does not use `variables` So at present, it seems that migration is `not necessary`. Of course, migration is also possible. - After complete the `last` structured log migration pr https://github.com/apache/spark/pull/46493/files on the java side, this rule should be applied to the spark code base (I have tested it on local env) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
