panbingkun commented on code in PR #46493: URL: https://github.com/apache/spark/pull/46493#discussion_r1596166648
########## common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java: ########## @@ -368,7 +382,8 @@ public int removeBlocks(String appId, String execId, String[] blockIds) { if (file.delete()) { numRemovedBlocks++; } else { - logger.warn("Failed to delete block: " + file.getAbsolutePath()); + logger.warn("Failed to delete block: {}", Review Comment: I'm not sure it's appropriate to call this `LogKeys.PATH$.MODULE$`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org