nikolamand-db commented on code in PR #46180: URL: https://github.com/apache/spark/pull/46180#discussion_r1601298545
########## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ########## @@ -772,12 +772,17 @@ object SQLConf { " produced by a builtin function such as to_char or CAST") .version("4.0.0") .stringConf - .checkValue(CollationFactory.isValidCollation, + .checkValue( + collationName => { + try { + CollationFactory.fetchCollation(collationName) + true + } catch { + case e: SparkException if e.getErrorClass == "COLLATION_INVALID_NAME" => false + } + }, Review Comment: `isValidCollation` would contain exception catching as part of its control flow, just as this approach does. Our reasoning was that it's better to scope this approach only here and not leave it open for use in other places. cc @dbatomic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org