nchammas commented on PR #46543: URL: https://github.com/apache/spark/pull/46543#issuecomment-2112900349
@MaxGekk @HyukjinKwon @cloud-fan - Before I finish up this PR, I'd like to check in with you briefly to make sure you like where this is going. The main idea in this PR is to deprecate public classes and parameters that use the old "error class" terminology and instead direct users to use "error condition". I'm trying wherever possible to do this in a backwards-compatible way. [Here's an example][ex] of the approach. In addition to being a bit gentler on users migrating to Spark 4.0, this will also help us avoid having to rename every instance of the `errorClass` or `error_class` parameters all across the codebase in one shot. Does this look good to you so far? In a similar vein, shall I keep incorrectly-named classes around but turn them into deprecated sub-classes of their correctly-named replacements? For example, `ErrorClassesJsonReader` would become a sub-class of `ErrorConditionsJsonReader`. [ex]: https://github.com/apache/spark/pull/46543/files#diff-d316cd1a4b3d10d5c8136adc63d0d56c74005a600bb966a1fd485347be1cd7e1R38-R49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
