dbatomic commented on code in PR #46599: URL: https://github.com/apache/spark/pull/46599#discussion_r1603367540
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CollationKey.scala: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.expressions + +import org.apache.spark.sql.catalyst.expressions.codegen.{CodegenContext, ExprCode} +import org.apache.spark.sql.catalyst.util.CollationFactory +import org.apache.spark.sql.internal.types.StringTypeAnyCollation +import org.apache.spark.sql.types._ +import org.apache.spark.unsafe.types.UTF8String + +case class CollationKey(expr: Expression) extends UnaryExpression with ExpectsInputTypes { + override def inputTypes: Seq[AbstractDataType] = Seq(StringTypeAnyCollation) + override def dataType: DataType = BinaryType + + final lazy val collationId: Int = expr.dataType match { + case st: StringType => + st.collationId + } + + override def nullSafeEval(input: Any): Any = input match { + case str: UTF8String => + CollationFactory.getCollationKeyBytes(str, collationId) + case _ => + None + } + + override protected def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = { + val collation = CollationFactory.fetchCollation(collationId) + if (collation.supportsBinaryEquality) { + defineCodeGen(ctx, ev, c => s"$c.getBytes()") + } else if (collation.supportsLowercaseEquality) { + defineCodeGen(ctx, ev, c => s"$c.toLowerCase().getBytes()") + } else { + defineCodeGen(ctx, ev, c => s"CollationFactory.fetchCollation" + Review Comment: You can use `getCollationKeyBytes` here? Also, IMO, you can just remove `getCollationKeyBytes` from collation factory and add the logic into `nullSafeEval`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
