HyukjinKwon commented on code in PR #46570:
URL: https://github.com/apache/spark/pull/46570#discussion_r1606684213
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -3507,6 +3513,47 @@ class SparkConnectPlanner(
.build())
}
+ private def handleCheckpointCommand(
+ checkpointCommand: CheckpointCommand,
+ responseObserver: StreamObserver[proto.ExecutePlanResponse]): Unit = {
+ val target = Dataset
+ .ofRows(session, transformRelation(checkpointCommand.getRelation))
+ val checkpointed = if (checkpointCommand.hasLocal &&
checkpointCommand.hasEager) {
Review Comment:
I just did it locally but I think it's actually better to keep just as is ..
I think the current one is easier to read .. `Dataset.checkpoint(eager:
Boolean, reliableCheckpoint: Boolean)` is private as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
